Replace synchronized method with private lock object in LlamaLoader#230
Merged
Conversation
Synchronize on a private static lock object instead of the LlamaLoader class's intrinsic lock, so untrusted code that can reach the public LlamaLoader type cannot acquire the same monitor and interfere with native-library initialization.
bernardladenthin
had a problem deploying
to
startgate
GitHub Actions
Error
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LlamaLoader.initialize()from a synchronized method to use a private lock object (INITIALIZE_LOCK) for synchronizationUSO_UNSAFE_STATIC_METHOD_SYNCHRONIZATIONby preventing untrusted code from acquiring the same intrinsic lock on the public classTest plan
Related issues / PRs
Checklist
CONTRIBUTING.mdandCODE_OF_CONDUCT.mdSECURITY.md)https://claude.ai/code/session_01W9s19iveUACGzehJs33Cm9